Ticket #93 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

duplicate cvar: "version" and "sv_version" / "cl_version"

Reported by: mdoison Owned by: mdoison
Priority: critical Milestone: Tag "eggy" version
Component: both Version: Eggy
Keywords: Cc:

Description (last modified by mdoison) (diff)

When we made sv_version and cl_version cvar, we forgot there is already a "version" cvar with same use.

So, we must remove sv_version and cl_version, and use same value for g_version, cg_version and version

"version" cvar format is: s = va("%s %s %s", Q3_VERSION, PLATFORM_STRING, __DATE__ );

where Q3_VERSION is game name and game version (here, "tremulous DnC-eggy") Does we need all of there information, or could we delete platform and/or date ?

Change History

Changed 3 years ago by amanieu

platform should be included, date is not needed, maybe also add arch

Changed 3 years ago by amanieu

We must be careful not to break any external server browsers who depend on this cvar

Changed 3 years ago by amanieu

Also, we should change this:

	#ifdef SVN_VERSION
	# define Q3_VERSION PRODUCT_NAME " " SVN_VERSION
	#else
	# define Q3_VERSION PRODUCT_NAME " " PRODUCT_VERSION
	#endif

to

	#define Q3_VERSION PRODUCT_NAME " " PRODUCT_VERSION " " SVN_VERSION

Changed 3 years ago by mdoison

  • owner changed from nobody to mdoison
  • status changed from new to assigned

Changed 3 years ago by mdoison

  • status changed from assigned to closed
  • resolution set to fixed
  • description modified (diff)

Done,

I made a new FULL_VERSION macro containing Q3_VERSION " " PLATFORM_STRING " " __DATE__

three cvar: version (for tremded and tremulous binaries), cg_version (for cgame file) and g_version (for game file)

Changed 3 years ago by mdoison

Hum, I didn't see amanieu comments when I resolved ticket.

I suggest to keep my last change for eggy (to be compatible with tremulous 1.1.0) and rethink version management for kitty

Note: See TracTickets for help on using tickets.